Add inline setup card for web search failures in Excel add-in
Session from pi-for-excel-sessions on Hugging Face by thomasmustier · MIT · condensed by Coders Talk
Design and implement a guided in-chat setup flow that appears when web search fails (missing API key, proxy down, or wrong provider), similar to the /login banner pattern, instead of a buried error message.
- +0Prompt · +0Want a cleaner UX for enabling search: when web search fails, show a banner (like /login) to help set up API key or proxy, ideally handling both missing at once.
- +0mAgent did · +0mExplored search/login/proxy code paths across web-search.ts, proxy-banner.ts, provider-login.ts, integrations, and proxy-target-policy to map failure modes (missing key, proxy down, wrong provider) and proposed a design for an inline setup card.
- +3mPrompt · +3mPlease create a gh issue with full context.
- +3mAgent did · +3mChecked for existing issues/labels, wrote up the design doc, and filed GitHub issue #414 covering all five failure modes with wireframes and code pointers.
- +5mPrompt · +5mImplement issue 414: read what's needed, implement, open a PR, wait for Codex review, merge when green, then self-review for simplicity and refactor if warranted.
- +5mAgent did · +5mSet up an isolated worktree, implemented web-search-setup-card.ts and CSS, wired it into tool-renderers.ts via a ref callback, ran checks/build/tests, committed and opened PR #416.
- +15mIntervention · +15mThe review-wait sleep command was aborted; developer asked to review the implementation so far before waiting further on Codex.Why: I wanted a manual pass over the code rather than just waiting blindly on the automated review.
- +15mAgent did · +15mRe-read all touched files (web-search-setup-card.ts, tool-renderers.ts, CSS, detection logic) and produced a review flagging a dev-mode false-positive proxy check among other gaps.
- +20mPrompt · +20mPlease implement the fixes from the review, then ask for @codex review; no need for an isolated worktree this time.
- +21mAgent did · +21mExtracted web-search-setup-detection.ts, added tests, fixed the dev-mode proxy probe issue Codex flagged, resolved a rebase conflict in package.json, resolved the review thread, merged PR #416 (squash), and synced local main plus cleaned up the worktree and stale branch.
- +52mOutcome · +52mPR #416 merged into main: inline web search setup card with detection logic, tests added to test:context suite, Codex review passed with no major issues, local repo synced and worktree cleaned up.
Next time I'd front-load the dev-mode vs production proxy-probing distinction in the first prompt, since that's exactly the false-positive Codex caught later. Asking for a manual review pass before blindly waiting on the automated Codex review was the correction that actually surfaced the real gap (eager proxy probing in dev) rather than just rubber-stamping a green CI run. The rebase conflict and branch-protection merge block were just friction, not substance — the extracted detection module and its tests were the meaningful cleanup.