Review Mac bootstrap/doctor script changes for correctness
Session from heypocket-reader-sessions on Hugging Face by thomasmustier · MIT · condensed by Coders Talk
2msession
0interventions
GOAL
Audit the working-tree diff of a Mac bootstrap/setup repo against origin/main for correctness, setup completeness, maintainability, and safety of the bootstrap/doctor flow.
- +0Prompt · +0Review the working tree changes in the bootstrap repo against origin/main for correctness, setup completeness, maintainability, and bootstrap/doctor safety; be concise and material only.
- +0mAgent did · +0mPulled the full diff stat and unified diff against origin/main, then inspected scripts/ensure-skill-vendors.py, merge-bootstrap-settings.py, Brewfile, and compared install.sh against the origin/main version.
- +0mAgent did · +0mSearched the repo for references to anthropics/skills, firecrawl-claude-plugin, and pi-for-word across scripts and vendor.lock.json to trace vendor/package dependencies.
- +1mAgent did · +1mRead through new-machine.sh, merge-bootstrap-settings.py, and settings.json line ranges to check the doctor/apply flag logic and settings merge behavior.
- +2mOutcome · +2mProduced a prioritized findings list, including a P1 bug where new-machine.sh silently skips --apply when any flag is passed (breaking --doctor installs) and a P1 issue with settings merge duplicating packages instead of migrating old source spellings.
VERDICT
I'd start the prompt the same way next time — asking for a focused, prioritized review against origin/main rather than a general once-over — since it got straight to real bugs instead of style nitpicks. The useful step was having it trace the new-machine.sh wrapper logic against bootstrap.sh's flag handling, which surfaced a real regression where --doctor silently stops installing anything.