Review pi-setup bootstrap script changes on macOS
Session from heypocket-reader-sessions on Hugging Face by thomasmustier · MIT · condensed by Coders Talk
1msession
0interventions
GOAL
Review working tree changes to a personal Mac bootstrap/setup repo against origin/main, checking correctness, setup completeness, maintainability, and safety of the bootstrap/doctor flow.
- +0Prompt · +0Review the diff of pi-setup-bootstrap against origin/main for correctness, setup completeness, maintainability, and bootstrap/doctor safety.
- +0mAgent did · +0mPulled the git diff and read through README.md, ensure-skill-vendors.py, merge-bootstrap-settings.py, and settings.json to understand the changes.
- +0mAgent did · +0mInspected Brewfile, bootstrap.sh, install.sh and re-read merge-bootstrap-settings.py line by line to trace how settings merging and dependency installation work.
- +1mOutcome · +1mDelivered findings, flagging a P2 issue: on a machine with a pre-existing ~/.pi/agent/settings.json, bootstrap never overrides stale defaults because the merge step only fills missing keys.
VERDICT
I'd start by pointing the agent straight at the merge/bootstrap scripts instead of the whole diff, since that's where the real risk was. The read-through of merge-bootstrap-settings.py twice is what surfaced the actual bug: on a partially-configured Mac, existing settings never get overwritten with the repo's intended defaults.